Signature validation before claim verification#160
Merged
excpt merged 7 commits intojwt:masterfrom Aug 23, 2016
excpt:issue-153
Merged
Signature validation before claim verification#160excpt merged 7 commits intojwt:masterfrom excpt:issue-153
excpt merged 7 commits intojwt:masterfrom
excpt:issue-153
Conversation
As mentioned in #153 by @koenbollen. The signature of the given JWT should always be checkedbefore any claim validation takes place.
|
Code looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JWT signature check should always be executed before any claim verification is triggered.
As explained in #153.