Do not strip leading zeros from trace IDs and span IDs#259
Do not strip leading zeros from trace IDs and span IDs#259yurishkuro merged 3 commits intojaegertracing:masterfrom tobiasstadler:jaegertracing-jaeger-1657
Conversation
|
✅ Build jaeger-client-cpp 172 completed (commit c19c41e689 by @tobiasstadler) |
Signed-off-by: Tobias Stadler <ts.stadler@gmx.de>
Signed-off-by: Tobias Stadler <ts.stadler@gmx.de>
|
✅ Build jaeger-client-cpp 173 completed (commit 582e56a4b7 by @tobiasstadler) |
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
Q: since you're looking into this, I just want too make sure there is a unit test that ensures that this library still CAN consume non-padded IDs from the incoming request headers
src/jaegertracing/TraceID.h
Outdated
| out << std::hex << _high << std::setw(16) << std::setfill('0') | ||
| << std::hex << _low; | ||
| } | ||
| out << std::setw(16) << std::setfill('0') << std::hex << _high |
There was a problem hiding this comment.
this does not seem backwards compatible, what's the reason for removing if (_high == 0) {?
There was a problem hiding this comment.
I though the trace id is now always 32 hex chars long. But I was wrong.
There was a problem hiding this comment.
No, all Jaeger SDKs still use 64bit by default, you have to explicitly enable 128bit.
There was a problem hiding this comment.
Yes, noticed that after your comment. I misread the prs for the other sdks.
TEST(SpanContext, testFromStream) tests both padded and unpadded trace ids |
Signed-off-by: Tobias Stadler <ts.stadler@gmx.de>
|
✅ Build jaeger-client-cpp 174 completed (commit 8cfcacf79f by @tobiasstadler) |
…#259) * Do not strip leading zeros from trace IDs Signed-off-by: Tobias Stadler <ts.stadler@gmx.de> * Do not strip leading zeros from span IDs Signed-off-by: Tobias Stadler <ts.stadler@gmx.de> * high should only be used if it is non zero Signed-off-by: Tobias Stadler <ts.stadler@gmx.de>
3 participants
Which problem is this PR solving?