This repository was archived by the owner on Aug 30, 2022. It is now read-only.
Add details on how to set agent & collector endpoints#153
Merged
yurishkuro merged 1 commit intojaegertracing:masterfrom Apr 5, 2019
Merged
Conversation
isaachier
approved these changes
Apr 3, 2019
Contributor
isaachier
left a comment
isaachier
left a comment
There was a problem hiding this comment.
LGTM, but leave it up to @yurishkuro.
yurishkuro
reviewed
Apr 4, 2019
Addresses jaegertracing#122 by adding details on how to set the agent host:port and the collector URL in the README. Signed-off-by: Mike Goldsmith <goldsmith.mike@gmail.com>
MikeGoldsmith
force-pushed
the
agent-collector-endpoint-docs
branch
from
ac60c12 to
2df0594
Compare
Contributor
Author
|
@yurishkuro I've applied your suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #122
Short description of the changes
Adds details on how to set the agent host:port and the collector URL in the README.