This repository was archived by the owner on Aug 30, 2022. It is now read-only.
Change sampler param sentinel value from YAML parser#145
Merged
isaachier merged 2 commits intojaegertracing:masterfrom Jan 2, 2019
Merged
Change sampler param sentinel value from YAML parser#145isaachier merged 2 commits intojaegertracing:masterfrom
isaachier merged 2 commits intojaegertracing:masterfrom
Conversation
Signed-off-by: andremarianiello <andremarianiello@users.noreply.github.com>
andremarianiello
force-pushed
the
fix-param-is-zero
branch
from
a92304a to
ff9cdc2
Compare
andremarianiello
changed the title
Member
|
is it possible to add a unit test? |
Signed-off-by: andremarianiello <andremarianiello@users.noreply.github.com>
Contributor
Author
|
@yurishkuro Added a test, which succeeds, and I verified that it failed without the sentinel value changes. |
Contributor
|
Let me take a look soon. |
andremarianiello
force-pushed
the
fix-param-is-zero
branch
from
07b46ab to
dfe64ed
Compare
Contributor
Author
|
Is there anything else I need to do for this? |
Contributor
|
Sorry thought @yurishkuro merged this. Will really try to get this in later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes