Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Adapt to new streamlit version + fix bug requiring --args to be supplied#621

Merged
aguschin merged 1 commit intomainfrom
fix/streamlit-args
Feb 27, 2023
Merged

Adapt to new streamlit version + fix bug requiring --args to be supplied#621
aguschin merged 1 commit intomainfrom
fix/streamlit-args

Conversation

@aguschin
Copy link
Contributor

@aguschin aguschin commented Feb 27, 2023

close #619

@aguschin aguschin requested a review from a team February 27, 2023 11:07
@aguschin aguschin self-assigned this Feb 27, 2023
@aguschin aguschin temporarily deployed to internal February 27, 2023 11:07 — with GitHub Actions Inactive
@aguschin aguschin enabled auto-merge (squash) February 27, 2023 11:07
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 86.17% // Head: 86.17% // No change to project coverage 👍

Coverage data is based on head (f53572e) compared to base (1a1d203).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files         107      107           
  Lines        9705     9705           
=======================================
  Hits         8363     8363           
  Misses       1342     1342           
Impacted Files Coverage Δ
mlem/contrib/streamlit/_template.py 0.00% <0.00%> (ø)
mlem/contrib/streamlit/server.py 66.98% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aguschin aguschin disabled auto-merge February 27, 2023 12:35
@aguschin aguschin merged commit c448416 into main Feb 27, 2023
@aguschin aguschin deleted the fix/streamlit-args branch February 27, 2023 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Adapt to streamlit changes

1 participant