Explicitly skip cudnn_rnn/miopen_rnn tests#3113
Open
Silv3S wants to merge 1 commit intointel:mainfrom
Open
Conversation
Silv3S
added
disable_e2e
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the XPU test skip list to explicitly skip fake-tensor RNN tests tied to CUDA-specific ATen operators that aren’t supported on the XPU backend (per issue #2472).
Changes:
- Adds targeted skips under
test_fake_tensor_xpu.pyfor cuDNN/miopen RNN-related coverage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+95
to
+99
| "test_fake_tensor_xpu.py": ( | ||
| # https://github.com/intel/torch-xpu-ops/issues/2472 | ||
| # aten::_cudnn_rnn/aten::miopen_rnn not supported | ||
| "test_cudnn_rnn", | ||
| ), |
There was a problem hiding this comment.
The PR title/comment says this change explicitly skips both cudnn_rnn and miopen_rnn tests, but the skip tuple currently only includes \"test_cudnn_rnn\". Either add the corresponding miopen_rnn test(s) here (if they exist in test_fake_tensor_xpu.py), or update the PR title/comment to match what’s actually being skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2472
As mentioned in original issue, there's no plan to support this CUDA specific aten operator on XPU backend.