Open
Conversation
Silv3S
added
disable_e2e
Silv3S
added
disable_accelerate
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the XPU test suite to avoid running map/map2 broadcast tests on XPU, matching CUDA behavior, because these ops (and their in-place variants) are CPU-only.
Changes:
- Extend
test_broadcastto early-return forfn in ["map", "map2"]on XPU as well as CUDA. - Remove
test_broadcast_fn_map_xpu/test_broadcast_fn_map2_xpufrom the XPU skip list since they should no longer fail.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/xpu/test_torch_xpu.py |
Skips map/map2 paths on XPU devices inside test_broadcast to prevent CPU-only op usage. |
test/xpu/skip_list_common.py |
Drops now-unnecessary skip-list entries for the broadcast map/map2 XPU tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2519
map and map2_ are only implemented on CPU tensors. CUDA has this tests skipped and XPU wasn't included on skiplist