Register jagged_to_padded_dense bool dispatch#3111
Open
Silv3S wants to merge 2 commits intointel:mainfrom
Open
Register jagged_to_padded_dense bool dispatch#3111Silv3S wants to merge 2 commits intointel:mainfrom
Silv3S wants to merge 2 commits intointel:mainfrom
Conversation
Silv3S
requested review from
CuiYifeng,
PawelSwider2000,
Copilot and
mwiktor-intel
Contributor
There was a problem hiding this comment.
Pull request overview
Adds XPU support for bool inputs in aten::_jagged_to_padded_dense_forward by extending the type dispatch in the SYCL kernel implementation, aligning it with existing dense_to_jagged behavior and addressing issue #2422.
Changes:
- Extend
jagged_to_padded_dense_forward_xpu_kerneldispatch to includeat::ScalarType::Bool.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/ATen/native/nested/xpu/sycl/NestedTensorTransformerFunctionKernels.cpp
Show resolved
Hide resolved
src/ATen/native/nested/xpu/sycl/NestedTensorTransformerFunctionKernels.cpp
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2422
This PR adds support for
boolinputs injagged_to_padded_denseop.dense_to_jaggedalready supports it.