Add Swift 6.1 manifest to forward Xet trait to swift-huggingface dependency#334
Merged
Add Swift 6.1 manifest to forward Xet trait to swift-huggingface dependency#334
swift-huggingface dependency#334Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Swift 6.1-specific package manifest so swift-transformers consumers can opt into the upstream swift-huggingface "Xet" trait (and therefore its Xet transport support) without imposing extra transitive dependencies by default.
Changes:
- Introduces
Package@swift-6.1.swiftusing SwiftPM 6.1 features to define an"Xet"trait at theswift-transformerspackage level. - Forwards the
"Xet"trait conditionally to theswift-huggingfacedependency when consumers enable it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattt
force-pushed
the
mattt/conditional-xet-support
branch
from
94be05f to
14d5986
Compare
pcuenca
reviewed
Mar 23, 2026
|
|
||
| test-linux: | ||
| name: Test (Linux) | ||
| name: Test (Linux)${{ matrix.traits != '' && format(' with --traits {0}', matrix.traits) || '' }} |
pcuenca
approved these changes
Mar 23, 2026
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Tested locally, amazing work! 🙌
Member
|
cc @ZachNagengast, this will be release 1.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #315
swift-xet depends on async-http-client for fast, parallel downloads. Unfortunately,
AsyncHTTPClienthas a bunch of transitive dependences, which some package consumers find unacceptable.huggingface/swift-huggingface#46 adds a new opt-in
"Xet"trait to conditionalize this dependency. This PR adds the plumbing required for consumers of the swift-transformers package to opt-in to that feature as well.