Make Message, ToolSpec, additionalContext sendable#298
Merged
mattt merged 1 commit intohuggingface:mainfrom Dec 10, 2025
Merged
Make Message, ToolSpec, additionalContext sendable#298mattt merged 1 commit intohuggingface:mainfrom
mattt merged 1 commit intohuggingface:mainfrom
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR enhances concurrency safety by making Message, ToolSpec, and additionalContext types Sendable, which enables better concurrency support in downstream packages like mlx-swift-lm.
- Changed
MessageandToolSpectype aliases from[String: Any]to[String: any Sendable] - Updated
additionalContextparameter type to[String: any Sendable]?across all function signatures
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattt
approved these changes
Dec 10, 2025
Collaborator
mattt
left a comment
mattt
left a comment
There was a problem hiding this comment.
Nice! Thank you, @DePasqualeOrg 🚀
Contributor
|
hey @mattt , is this going to be released in a version soon? |
Contributor
Author
|
@mattt, could you make a new release so that this gets picked up in downstream packages? Thanks. |
Member
|
Doing a release now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help with concurrency fixes in downstream packages like mlx-swift-lm.