[opt] Fix in attention after transformers upgrade#2276
Merged
regisss merged 1 commit intohuggingface:mainfrom Sep 22, 2025
Merged
[opt] Fix in attention after transformers upgrade#2276regisss merged 1 commit intohuggingface:mainfrom
regisss merged 1 commit intohuggingface:mainfrom
Conversation
This commit fixes two issues that appeared in opt attention after transformers upgrade. * incorrect shape of attn_weights caused mismatch in subsequent torch.bmm operation * applying scaling to attn_weights significantly worsened accuracy Signed-off-by: Urszula <urszula.golowicz@intel.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
"Next Synapse Release Validation" is failing on one test with unrelated reason. It looks clean. |
Collaborator
|
LGTM, @regisss can we merge this? |
astachowiczhabana
approved these changes
Sep 22, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 23, 2025
Signed-off-by: Urszula <urszula.golowicz@intel.com>
astachowiczhabana
added a commit
that referenced
this pull request
Sep 23, 2025
This reverts commit 4ac187f.
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
…uggingface#714) Signed-off-by: Urszula <urszula.golowicz@intel.com> Co-authored-by: Urszula Golowicz <urszula.golowicz@intel.com>
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Nov 6, 2025
…uggingface#714) Signed-off-by: Urszula <urszula.golowicz@intel.com> Co-authored-by: Urszula Golowicz <urszula.golowicz@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes two issues that appeared in opt attention after transformers upgrade.
This change should also be applied to v1.20-release
Example: