Merged
Conversation
claire-labry
force-pushed
the
migrate-v2-to-gha
branch
2 times, most recently
from
93b0d00 to
22936d5
Compare
add back gcs and s3 components add smb tests and more go versions whoops change to ubuntu remove tags for now reshifting reshifting testing linux only shifiting again try docker build fix TTY message try to fix windows add git config for submodule remove out error fix window tests disable window tests for now
claire-labry
force-pushed
the
migrate-v2-to-gha
branch
from
a3a9926 to
7f9f4aa
Compare
nywilken
reviewed
Oct 25, 2022
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
nywilken
approved these changes
Oct 25, 2022
Contributor
nywilken
left a comment
nywilken
left a comment
There was a problem hiding this comment.
@claire-labry this looks great. I left a nit but this is good to go.
Thanks again for working through this.
picatz
reviewed
Oct 26, 2022
Co-authored-by: Kent 'picat' Gruber <kent@hashicorp.com>
picatz
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates
v2ofgo-getterto GHA from CircleCI.