Fix ModuleNotFoundError: No module named 'pymatgen.transformations.defect_transformations'#760
Merged
Zhuoying merged 14 commits intohackingmaterials:mainfrom Aug 27, 2022
janosh:main
Merged
Fix ModuleNotFoundError: No module named 'pymatgen.transformations.defect_transformations'#760Zhuoying merged 14 commits intohackingmaterials:mainfrom janosh:main
ModuleNotFoundError: No module named 'pymatgen.transformations.defect_transformations'#760Zhuoying merged 14 commits intohackingmaterials:mainfrom
janosh:main
Conversation
bump actions/checkout to v3, actions/setup-python to v4
…fect_transformations' by adding pymatgen-analysis-defects to setup.py install_requires this is necessary following pymatgen release v2022719 https://github.com/materialsproject/pymatgen/blob/master/CHANGES.rst#v2022719
janosh
changed the title
setup-python built-in dependency caching in GitHub actionsModuleNotFoundError: No module named 'pymatgen.transformations.defect_transformations'
following @jmmshn's recommendation, see materialsproject/pymatgen#2582 (comment)
also pre-commit autoupdate add flags --remove-unused-variables --expand-star-imports to autoflake hook
…from floating point errors
Collaborator
|
Thanks, @janosh for the fixing. I am merging it for now, so Jimmy can work on the defect wf on top of this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also
.github/workflows/test.ymlto usesetup-pythonbuilt-in dependency caching for GitHub actionsblackversion used bypre-commitactions/checkoutto v3,actions/setup-pythonto v4