Merged
Conversation
Collaborator
|
Hi, @jmmshn Thanks for this PR. I will merge it for now. If there is an issue later, pls feel free to let us know. BTW: The failed pytest actually was fixed already (#747). It would be great if you could git pull first before git push to avoid this for the next time. Please bear my OCD for all green tests.😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boto3.clienttoboto3.resourcesto better match whatmaggmadoes. Also I was failing tests because it seems like the AWS API no longer liked me usingboto3.client.create_bucketin the way this was originally written.scipyversion (Ubuntu with python 3.9 and 3.10) so I bumped it to the nearest > version.qchemtests on the GitHub workflows should we turn it off insetup.cfgas well? It took a long time for me to figure out why all my tests were failing.