Fix gzip contcar issue#745
Merged
itsshawnwang merged 2 commits intohackingmaterials:mainfrom Feb 3, 2022
Merged
Conversation
Collaborator
|
Thanks @fraricci for your contribution. I will merge this PR now and please let me know if there is any further problems or questions. Cheers! : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue of the interpolation FW which currently does not find the CONTCAR file if its gzipped.
If the CONTCAR file is not gzipped, it still works fine.
More generally, this fix allows CopyFilesFromCalcLoc to decompress compressed file after copy if wanted.
This fix should solve previous raised issues (I can find them back now).