use pytest-split in GHA test workflow#739
Merged
itsshawnwang merged 6 commits intohackingmaterials:mainfrom Apr 18, 2022
janosh:pytest-split
Merged
use pytest-split in GHA test workflow#739itsshawnwang merged 6 commits intohackingmaterials:mainfrom janosh:pytest-split
itsshawnwang merged 6 commits intohackingmaterials:mainfrom
janosh:pytest-split
Conversation
…::TestLobsterRunToDb::test_jsonfile_si'
also fix staticmethod using self
Collaborator
|
Hello @janosh! Sorry about the delay. I will merge this PR now and please let me know for any other problems or concerns. |
Member
Author
|
Tbh, I'm not sure the potential CI speed up from this change is worth the added complexity. I guess we can try it out on |
Collaborator
|
@janosh Sure thing! |
Collaborator
|
@janosh I think I need to revert this PR since several errors arose by the |
Member
Author
|
Feel free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the initially longer than expected runtime of
pytestin #734, I looked around a bit for a pytest plugin that would automatically distribute the workload among multiple concurrent runners.Luckily, exactly such a thing exists. Never used it before but looks great.
https://github.com/jerry-git/pytest-split
And they even have a GHA demo:
https://github.com/jerry-git/pytest-split-gh-actions-demo/tree/master/.github/workflows
Let's see if I set this up correctly. :)