Skip to content

Set first amount to max limit if not set#993

Merged
jkimbo merged 1 commit intomasterfrom
fix-relay-max-limit-no-first
Jun 25, 2020
Merged

Set first amount to max limit if not set#993
jkimbo merged 1 commit intomasterfrom
fix-relay-max-limit-no-first

Conversation

@jkimbo
Copy link
Member

@jkimbo jkimbo commented Jun 25, 2020

Related to #986

This PR fixes the issue with hasNextPage not being True when first is not passed to the query but RELAY_CONNECTION_MAX_LIMIT is set.

@jkimbo jkimbo requested review from a user, ulgens and zbyte64 June 25, 2020 12:04
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkimbo jkimbo merged commit 3026181 into master Jun 25, 2020
@jkimbo jkimbo deleted the fix-relay-max-limit-no-first branch June 25, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant