Merged
Conversation
|
This fix works for me (Chrome on Mac). |
|
This fix also works for me (Brave on Mac) |
jaw9c
approved these changes
May 3, 2023
Collaborator
jaw9c
left a comment
There was a problem hiding this comment.
Looks good, nice cleanup too 👍
Merged
firaskafri
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1402
After upgrading GraphiQL to v2.4.1 (#1396) all requests seem to fail on Chrome and Safari but works on Firefox. Unfortunately while working on that PR I tested exclusively on Firefox and didn't catch this.
The problem seems to be caused by this line.
graphene-django/graphene_django/static/graphene_django/graphiql.js
Line 78 in 34cc860
Also took this opportunity to simplify the GraphQL fetcher logic.
AcceptandContent-Typeare automatically taken care of and don't need setting explicitly.A more detailed explanation of the bug:
content-type: application/jsonis automatically added and so we have bothcontent-typeandContent-Typein theheadersobject which somehow got turned intocontent-type: application/json, application/jsonwhich is invalid.@sparktx-adam-gleason @dicknetherlands could you help test this with