Make errors in form mutation non nullable#1286
Merged
firaskafri merged 1 commit intographql-python:mainfrom Sep 23, 2022
Merged
Make errors in form mutation non nullable#1286firaskafri merged 1 commit intographql-python:mainfrom
firaskafri merged 1 commit intographql-python:mainfrom
Conversation
keithhackbarth
approved these changes
Jan 24, 2022
Collaborator
keithhackbarth
left a comment
keithhackbarth
left a comment
There was a problem hiding this comment.
This looks simple and straightforward enough for me. Nice work.
firaskafri
approved these changes
Sep 22, 2022
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DjangoModelFormMutationdoes not return null in errors field. If form is valid, errors will be empty array. If form invalid, errors will be filled asErrorType.Specification https://spec.graphql.org/June2018/#sec-Type-System.Non-Null says in this case non-null values should be returned. So it makes sense to simplify type validation on client-side.