Fix broken form.save() call in DjangoFormMutation.perform_mutate#1155
Merged
zbyte64 merged 1 commit intographql-python:mainfrom Apr 11, 2021
ruohola:fix-django-form-mutation
Merged
Fix broken form.save() call in DjangoFormMutation.perform_mutate#1155zbyte64 merged 1 commit intographql-python:mainfrom ruohola:fix-django-form-mutation
form.save() call in DjangoFormMutation.perform_mutate#1155zbyte64 merged 1 commit intographql-python:mainfrom
ruohola:fix-django-form-mutation
Conversation
form.save() call in DjangoFormMutation.perform_mutate
Django's plain (non-model) forms don't have the `save` method, so calling this would just result in an `AttributeError` before this change. Resolves #1152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django's plain (non-model) forms don't have the
savemethod, socalling this would just result in an
AttributeErrorbefore thischange.
Resolves #1152
Didn't want to just remove the
form.save()line completely, since the tests at least "document" it as a valid usage to pass aModelFormas theform_classof a plainDjangoFormMutation:graphene-django/graphene_django/tests/mutations.py
Lines 9 to 11 in 80ea51f
(
PetFormis aforms.ModelFormhere)