Fix main branch tests failing due to wrong instancing of Missing class#1135
Merged
zbyte64 merged 1 commit intographql-python:mainfrom Mar 2, 2021
Merged
Fix main branch tests failing due to wrong instancing of Missing class#1135zbyte64 merged 1 commit intographql-python:mainfrom
zbyte64 merged 1 commit intographql-python:mainfrom
Conversation
zbyte64
approved these changes
Mar 2, 2021
Collaborator
zbyte64
left a comment
zbyte64
left a comment
There was a problem hiding this comment.
Thank you for catching that. Just the one question 👍
| @@ -1,5 +1,6 @@ | |||
| class MissingType(object): | |||
| pass | |||
| def __init__(self, *args, **kwargs): | |||
Collaborator
There was a problem hiding this comment.
Not sure why this is needed?
Contributor
Author
There was a problem hiding this comment.
When you are initializing things like the ArrayField it will send some args to the constructor that by default the MissingType is not expecting and therefore will fail saying that the Field was overloaded
tcleonard
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main tests are broken in the main branch because the MissingType does not take any arguments.