BUGFIX: don't filter out lookup_field as input (required for update)#1029
Merged
jkimbo merged 2 commits intographql-python:masterfrom Oct 19, 2020
Merged
Conversation
jkimbo
approved these changes
Oct 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
SerializerMutationthe pkey/lookup field is filtered out. see (#906). It was introduced by #882.This seems incorrect.
graphene-django/graphene_django/rest_framework/mutation.py
Line 120 in ac1f9ac
The workaround #906 (comment) does not work with relay. (Id field are typically numeric vs string for relay ids)