Skip to content

Pointer semantics in depthCounter #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guelfey merged 1 commit into from
Apr 8, 2023
+6 −6
Merged

Pointer semantics in depthCounter #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,19 +183,19 @@ func (cnt *depthCounter) Valid() bool {
return cnt.arrayDepth <= 32 && cnt.structDepth <= 32 && cnt.dictEntryDepth <= 32
}

func (cnt depthCounter) EnterArray() *depthCounter {
func (cnt *depthCounter) EnterArray() *depthCounter {
cnt.arrayDepth++
return &cnt
return cnt
}

func (cnt depthCounter) EnterStruct() *depthCounter {
func (cnt *depthCounter) EnterStruct() *depthCounter {
cnt.structDepth++
return &cnt
return cnt
}

func (cnt depthCounter) EnterDictEntry() *depthCounter {
func (cnt *depthCounter) EnterDictEntry() *depthCounter {
cnt.dictEntryDepth++
return &cnt
return cnt
}

// Try to read a single type from this string. If it was successful, err is nil
Expand Down