ref(browser): Create standalone INP spans via startInactiveSpan#11788
Merged
ref(browser): Create standalone INP spans via startInactiveSpan#11788
startInactiveSpan#11788Conversation
Lms24
changed the base branch from
develop
to
lms/feat-core-span-envelope-trace-header
AbhiPrasad
approved these changes
Apr 25, 2024
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-core-span-envelope-trace-header
branch
from
47a67db to
5095e82
Compare
Base automatically changed from
lms/feat-core-span-envelope-trace-header
to
develop
April 25, 2024 15:19
Lms24
force-pushed
the
lms/ref-browser-inp-standalone-span
branch
from
28df9db to
3a547f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds on top of #11696 #11699
This PR refactors how we create INP spans. Previously we'd directly initialize a
SentrySpaninstance with the necessary properties and manually sample the span. Ironically, we heavily discourage directly initializing aSpanclass.With this refactor PR, we leverage the
standalone: trueflag introduced in #11696. This way, we can also use the built-in sampling functionality and ensure that we only have one logic for creating standalone span envelopes. Also bundle size should decrease slightly 🤞Adjusted the integration tests to more thoroughly test the INP span envelopes