Improve performance of `uuid4` function

[AbhiPrasad]

Description

uuid4 is expensive

sentry-javascript/packages/core/src/utils-hoist/misc.ts

Line 28 in ef2f35d

export function uuid4(crypto = getCrypto()): string {

[timfish]

My testing of uuid4() on Node v20 (ie. hitting crypto.randomUUID()) suggests it takes under 0.001ms.

Maybe crypto.randomUUID() is being polyfilled with something that isn't as good as Nodes native code? Even then, 170ms seems suspiciously high!

[AbhiPrasad]

@timfish this is a sandwich view, so it's an aggregate time. Perhaps it being called so much is nothing we can avoid.

[timfish]

It would certainly make it quicker if we didn't have to remove the hyphens. Or maybe there's a faster way than the regex as we know the positions of them. Ideally we'd want to avoid the extra allocation!

[timfish]

Just checked develop.sentry.io and for uuids, its says:

UUIDs are declared as either 32 character hexadecimal strings without dashes ("12c2d058d58442709aa2eca08bf20986"), or 36 character strings with dashes ("12c2d058-d584-4270-9aa2-eca08bf20986"). It is recommended to omit dashes and use UUID v4 in all cases.

But in plenty of other places it also says it expects 32 character uuids without dashes 🤷‍♂️

Maybe we can keep the dashes in all cases on the client but we'd give Relay extra work because they'll all need normalising to 32 characters without dashes?

[AbhiPrasad]

Maybe we can keep the dashes in all cases on the client but we'd give Relay extra work because they'll all need normalising to 32 characters without dashes?

IMO giving relay extra work is no big deal, but we do then have friction where the uuid we display in the UI is different than the logged out json from the sdk