feat(eap): Add AttributeValue data structure#4627
Closed
Dav1dde wants to merge 2 commits intodav1d/flatten-attributesfrom
Closed
feat(eap): Add AttributeValue data structure#4627Dav1dde wants to merge 2 commits intodav1d/flatten-attributesfrom
Dav1dde wants to merge 2 commits intodav1d/flatten-attributesfrom
Conversation
83441c7 to
53551f7
Compare
Member
Author
|
This approach of 'validating' during deserialization is not feasible due to needing large boilerplate of manually implementing macros and still leaving open misconfigurations through the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #4592 and future EAP envelope items (Spans).
The PR itself only adds the data structure, but it is still unused, to prevent clashes with the still different OurLogs implementation, that one was renamed (until it is removed).
TODO:
ProcessValue#skip-changelog