handle null method when using autofocus on field#8
Merged
erikras merged 1 commit intofinal-form:masterfrom Dec 24, 2018
Merged
Conversation
voxtex
force-pushed
the
autofocus-fix
branch
from
ef1220b to
a4be08c
Compare
Contributor
Author
|
As I was playing around with this I found a better fix. Instead of working around the problem, correctly record the scenario where field state is unavailable to call focus in a ref and then invoke it the next time the subscriber gets invoked. |
Member
|
Interesting. Seems legit. 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Member
|
Published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an input has
autofocus={true}attribute, state.focus is not initialized the first time the method is invoked. Couldn't find a way to force this to initialize prior to being invoked by autofocus, at the very least this will stop an exception that prevents react from rendering.