fix(useForm): Use memoized form instance of lazy getter.#25
Merged
erikras merged 1 commit intofinal-form:masterfrom Mar 4, 2019
avocadowastaken:fix-form
Merged
fix(useForm): Use memoized form instance of lazy getter.#25erikras merged 1 commit intofinal-form:masterfrom avocadowastaken:fix-form
form instance of lazy getter.#25erikras merged 1 commit intofinal-form:masterfrom
avocadowastaken:fix-form
Conversation
avocadowastaken
changed the title
form instance of lazy getter.form instance of lazy getter.
Contributor
|
Latest version is completely broken because of this, fix looks good to me. |
Contributor
|
Any particular reason for the delay on merging this? The entirely library is currently broken. |
Member
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced new bug #20, where
formref object was handled asforminstance. Copy/pasting from my local form hook didn't well.@erikras pls review :) it's a bit critical.