fix: React is not defined compilation error after ejected#9885
Merged
ianschmitz merged 1 commit intofacebook:masterfrom Oct 26, 2020
Merged
fix: React is not defined compilation error after ejected#9885ianschmitz merged 1 commit intofacebook:masterfrom
React is not defined compilation error after ejected#9885ianschmitz merged 1 commit intofacebook:masterfrom
Conversation
n3tr
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
Contributor
|
@n3tr Seems the change is already done by another PR and is merged. |
ianschmitz
changed the title
React is not defined compilation error after ejectedReact is not defined compilation error after ejected
Contributor
|
Thanks for the fixes @n3tr! |
wombleton
pushed a commit
to AurorNZ/create-react-app
that referenced
this pull request
Jun 1, 2021
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 19, 2023
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #9882
Eject the app will cause
React is not defined, This is due to the Babel's configuration for JSX runtime gets removed during ejecting.Change
runtimeconfiguration on ejectionVerify Steps
yarn create-react-app test-ejecting-appcd test-eject-appyarn ejectyarn startand app should gets compiled successfully