Skip to content

docs: replace dummy with placeholder in example comments#7064

Merged
bjohansebas merged 2 commits intoexpressjs:masterfrom
stuckvgn:inclusive-language-examples
Mar 1, 2026
Merged

docs: replace dummy with placeholder in example comments#7064
bjohansebas merged 2 commits intoexpressjs:masterfrom
stuckvgn:inclusive-language-examples

Conversation

@stuckvgn
Copy link
Contributor

Summary

  • Replaces the term dummy with placeholder in three example file comments
  • No functional changes - these are comment-only updates
  • Aligns with inclusive language best practices

Files changed

  • examples/ejs/index.js: Dummy users to Placeholder users
  • examples/route-middleware/index.js: Dummy users to Placeholder users
  • examples/auth/index.js: dummy database to placeholder database

Context

The Inclusive Naming Initiative lists dummy as a Tier 3 term to replace when possible. Placeholder is a more precise and neutral alternative that better describes the purpose of the test data in these examples.

Test plan

  • No tests affected - changes are limited to code comments in example files
  • Verified no other occurrences of dummy exist in the examples directory

Use more inclusive language in code comments across example files.
The term 'dummy' can be replaced with the clearer, more neutral
term 'placeholder' without any change in meaning.

Files changed:
- examples/ejs/index.js
- examples/route-middleware/index.js
- examples/auth/index.js
@UlisesGascon
Copy link
Member

UlisesGascon commented Feb 25, 2026

the CI issue is not related to this (503 code error in the coverage upload service), I can retry it again in few hours (ref):

<p>You've requested a page on a website (coveralls.io) that is on the <a href="https://www.cloudflare.com/5xx-error-landing/" target="_blank">Cloudflare</a> network. Cloudflare is currently unable to resolve your requested domain (coveralls.io).</p>

@stuckvgn
Copy link
Contributor Author

Thanks for the context, @UlisesGascon — just tried pushing a re-trigger commit and hit the same coveralls.io 503. Will leave it with you to retry once the service recovers.

@stuckvgn
Copy link
Contributor Author

@UlisesGascon Quick nudge — any chance the coverage job can be re-run or bypassed for merge? All tests pass across the full Node matrix, it's just the coveralls 503 holding things up.

@stuckvgn
Copy link
Contributor Author

stuckvgn commented Mar 1, 2026

Hi @UlisesGascon — the PR has two approvals and all Node matrix tests pass. The only failing check is the Coveralls coverage step which is hitting a 503 from the Coveralls service (external infrastructure issue, not related to this change). Would you be able to re-trigger that check or merge despite it? Happy to wait if there's a preferred process for this.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@bjohansebas
Copy link
Member

Please don’t tag people manually 🙂

@bjohansebas bjohansebas merged commit 6c4249f into expressjs:master Mar 1, 2026
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants