This repository was archived by the owner on Jan 18, 2024. It is now read-only.
Conversation
Contributor
|
My only concern is that the version bump is going to cause a major regression in our installation size, because
and this: (the other versions are from As you can see, inquirer is ~24MB unpacked. Most of that, ~17MB of that comes from Solutions:
|
Contributor
|
Opened a PR to replace inquirer with prompts in create-react-app facebook/create-react-app#10083 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
bump inquirer to fix some problems we were experiencing
fixes #2224
breaking changes
afaik the bump from 5.2.0 to 7.3.0 doesn't affect us. The breaking changes include:
For more details, see these inquirer release notes
manual tests