Skip to content
This repository was archived by the owner on Jan 18, 2024. It is now read-only.

[cli][xdl] bump inquirer#2337

Closed
quinlanj wants to merge 1 commit intomasterfrom
@quin/bumpInquirer
Closed

[cli][xdl] bump inquirer#2337
quinlanj wants to merge 1 commit intomasterfrom
@quin/bumpInquirer

Conversation

@quinlanj
Copy link
Member

@quinlanj quinlanj commented Jul 2, 2020

why

bump inquirer to fix some problems we were experiencing
fixes #2224

breaking changes

afaik the bump from 5.2.0 to 7.3.0 doesn't affect us. The breaking changes include:

  • Update to Rx.js v6
  • Dropping support for Node 6

For more details, see these inquirer release notes

manual tests

  • ran a couple of expo cli commands that have prompts in them to do a quick sanity check

@quinlanj quinlanj requested a review from fson July 2, 2020 20:43
@fson
Copy link
Contributor

fson commented Jul 3, 2020

My only concern is that the version bump is going to cause a major regression in our installation size, because react-dev-tools still depends on an older version of inquirer, so we end up depending on both.

yarn why inquirer shows both this:

=> Found "inquirer@7.0.4"
info Has been hoisted to "inquirer"
info Reasons this module exists
   - "workspace-aggregator-c7915d7a-6a15-4094-ae38-e5832b4eb142" depends on it
   - Hoisted from "_project_#eslint#inquirer"
   - Hoisted from "_project_#@expo#webpack-config#react-dev-utils#inquirer"
info Disk size without dependencies: "448KB"
info Disk size with unique dependencies: "22.8MB"
info Disk size with transitive dependencies: "24.05MB"

and this:

=> Found "expo-cli#inquirer@7.3.0"
info This module exists because "_project_#expo-cli" depends on it.
info Disk size without dependencies: "216KB"
info Disk size with unique dependencies: "22.57MB"
info Disk size with transitive dependencies: "23.82MB"

(the other versions are from devDependencies so they shouldn't have an effect).

As you can see, inquirer is ~24MB unpacked. Most of that, ~17MB of that comes from rxjs, and since inquirer bumped the rxjs version, we would depend on two versions of rxjs after this change.

Solutions:

@quinlanj quinlanj closed this Nov 4, 2020
@EvanBacon
Copy link
Contributor

Opened a PR to replace inquirer with prompts in create-react-app facebook/create-react-app#10083

@EvanBacon EvanBacon deleted the @quin/bumpInquirer branch November 16, 2020 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cli] list/checkboxes broken with multiline choices

3 participants