Skip to content

Fix implicit clone warning in satellite example#278

Merged
kahgoh merged 1 commit intoexercism:mainfrom
kahgoh:fix/satellite
Oct 26, 2025
Merged

Fix implicit clone warning in satellite example#278
kahgoh merged 1 commit intoexercism:mainfrom
kahgoh:fix/satellite

Conversation

@kahgoh
Copy link
Member

@kahgoh kahgoh commented Oct 25, 2025

Fixes the following type of warning:

Notice: temp/satellite.v:54:21: notice: an implicit clone of the slice was done here
   52 |
   53 |     value := preorder[0]
   54 |     preorder = preorder[1..(preorder.len)]
      |                        ~~~~~~~~~~~~~~~~~~~
   55 |
   56 |     left := traverse(value, mut preorder, mut inorder)!
Details: temp/satellite.v:54:21: details: To silence this notice, use either an explicit `a[..].clone()`,
or use an explicit `unsafe{ a[..] }`, if you do not want a copy of the slice.
   52 |
   53 |     value := preorder[0]
   54 |     preorder = preorder[1..(preorder.len)]
      |                        ~~~~~~~~~~~~~~~~~~~
   55 |
   56 |     left := traverse(value, mut preorder, mut inorder)

Fixes the following type of warning:

Notice: temp/satellite.v:54:21: notice: an implicit clone of the slice was done here
   52 |
   53 |     value := preorder[0]
   54 |     preorder = preorder[1..(preorder.len)]
      |                        ~~~~~~~~~~~~~~~~~~~
   55 |
   56 |     left := traverse(value, mut preorder, mut inorder)!
Details: temp/satellite.v:54:21: details: To silence this notice, use either an explicit `a[..].clone()`,
or use an explicit `unsafe{ a[..] }`, if you do not want a copy of the slice.
   52 |
   53 |     value := preorder[0]
   54 |     preorder = preorder[1..(preorder.len)]
      |                        ~~~~~~~~~~~~~~~~~~~
   55 |
   56 |     left := traverse(value, mut preorder, mut inorder)
@kahgoh kahgoh merged commit 400f30a into exercism:main Oct 26, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants