Added GoReleaser config, updated docs, made archive naming adjustments#886
Merged
kytrinyx merged 1 commit intoexercism:masterfrom Oct 11, 2019
ekingery:master
Merged
Added GoReleaser config, updated docs, made archive naming adjustments#886kytrinyx merged 1 commit intoexercism:masterfrom ekingery:master
kytrinyx merged 1 commit intoexercism:masterfrom
ekingery:master
Conversation
kytrinyx
requested changes
Oct 9, 2019
Member
kytrinyx
left a comment
kytrinyx
left a comment
There was a problem hiding this comment.
This looks good! Thank you so much for taking the time to work through this whole process.
Would you mind rebasing onto master and editing the commit to run gofmt on it?
Contributor
Author
Absolutely. This is done and the build is passing. The rebase got a little messy but I think everything looks OK now. |
kytrinyx
approved these changes
Oct 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using GoReleaser and closes #700. Additional information on the transition to GoReleaser and adding Snap support for Linux is available here: https://gist.github.com/ekingery/4732af2a828d5992b1cc69d07c87778d
For reference, you can find a test release on my fork: https://github.com/ekingery/cli/releases/tag/v3.0.38