Fix panic when submit not given args#797
Merged
kytrinyx merged 3 commits intoexercism:masterfrom Feb 26, 2019
Merged
Conversation
Previously, submit panics when not given args due when trying to index
an empty array:
exercise, err := ctx.exercise(submitPaths[0])
jdsutherland
force-pushed
the
submit-handles-no-args
branch
from
eaed803 to
6f8b1be
Compare
Member
|
@jdsutherland Life intruded, and I have failed to check in on all the CLI work! I'm so sorry to have left you hanging. I'm going to go through all the open work and see where we are, and see if I can get back on track. |
Contributor
Author
|
@kytrinyx no problem! I don't think any sane person should expect this to be a priority over life stuff. Take your time. |
kytrinyx
approved these changes
Feb 26, 2019
Member
kytrinyx
left a comment
kytrinyx
left a comment
There was a problem hiding this comment.
Thank you! This is a great catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, submit panics when run without args (i.e.,
exercism submit) due to attempting to indexan empty slice: