Update max allowed file size error to include filename#739
Merged
nywilken merged 1 commit intoexercism:masterfrom Sep 22, 2018
Merged
Update max allowed file size error to include filename#739nywilken merged 1 commit intoexercism:masterfrom
nywilken merged 1 commit intoexercism:masterfrom
Conversation
nywilken
changed the title
nywilken
force-pushed
the
enormous-file-message
branch
from
bb9140b to
e58f35b
Compare
kytrinyx
approved these changes
Sep 20, 2018
Member
kytrinyx
left a comment
kytrinyx
left a comment
There was a problem hiding this comment.
This is a great catch, thank you!
Contributor
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when submitting a file that is larger than the max allowed size the user receives an error indicating that a submitted file is larger than the max allowed file size, but it does not include the actual name of the file.
This is not really an issue when submitting a single file, but when a user submits two or more files the error message is a bit of a guessing game.