Improve the API ping in configure command#679
Merged
Conversation
nywilken
reviewed
Jul 25, 2018
cmd/configure.go
Outdated
| @@ -93,7 +93,11 @@ func runConfigure(configuration config.Configuration, flags *pflag.FlagSet) erro | |||
|
|
|||
| ok, err := client.IsPingable() | |||
| if !ok || err != nil { | |||
Contributor
There was a problem hiding this comment.
The IsPingable method seems to imply if there is an error than the client is not technically not reachable. If that is always going to be the case should we just check if err != nil and drop the !ok?
Member
Author
There was a problem hiding this comment.
Yeah, now that the IsPingable() returns an error, we can simplify.
This distinguishes between an error in the HTTP request (e.g. no service at URL), and an error returned from the API (e.g. 500 error).
1a9aa41 to
239f303
Compare
Member
Author
|
I've tweaked based on your feedback, @nywilken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This distinguishes between an error in the HTTP request (e.g.
no service at URL), and an error returned from the API (e.g. 500 error).
Previous output in the case of an HTTP 500
Now: