Fix problem with downloading another person's solution using the --uuid flag#641
Merged
Fix problem with downloading another person's solution using the --uuid flag#641
Conversation
added 3 commits
July 14, 2018 17:57
The fake download server hardcodes responses, effectively hiding information. Since the setup in the test doesn't obviously create the data, it makes some sort of sense to hide the filenames in the assertion. I don't massively like it, but I think it kind of makes sense for now.
You should be able to download by an exercise name or a uuid. This adds a test for the uuid case.
When downloading someone else's solution, we weren't creating the necessary directories before trying to write the file to the target directory.
Member
Author
|
Merging so I can get one more fix in before this flight leaves (and so I can cut a release!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were failing to do a
mkdir -pbefore trying to write files when downloading someone else's solution.Closes #621