Add shell completions and README to build script#616
Conversation
Completion scripts currently live in the CLI website repository which is deemed inappropriate Update build script to add shell completions and README to tar/zips
|
From #394:
I have no prior experience with the homebrew repo but it seems https://github.com/Homebrew/homebrew-core/blob/c53141dcda9d1a062eba89f77a5c02f09f6b5bd2/Formula/fzf.rb#L52 + fzf/shell might help. |
kytrinyx
left a comment
There was a problem hiding this comment.
Thank you! This will be such a relief to get done.
bin/build-all
Outdated
| BINNAME=${NAME:-exercism} | ||
|
|
||
| get_shell_completions() { | ||
| SHELLCOMP_BASEURL=http://cli.exercism.io/shell/exercism_completion |
There was a problem hiding this comment.
Let's keep the scripts in this repository instead of in the static HTML repo (as you suggested). That way this will be a simple file inclusion rather than a network call.
1cf2310 to
f6880d9
Compare
kytrinyx
left a comment
There was a problem hiding this comment.
I like the direction of this. A few things:
- the build doesn't bail, but the resulting artifacts won't extract because it contains
../ - let's move the
BUILD.mdintoshell/and rename it toREADME.md
|
Here's the error I got when I tried to extract the archive: |
Avoid including 'out' directory in generated archive tar and zip differ in how to achieve this tar -C will cd to dir before adding files. zip cd subshell accomplishes the same thing.
|
FYI: I changed the base of this PR to point to master (I've been changing branches around, so what is on master now is what was previously on nextercism). |
|
❤️ 💛 💚 💙 💜 🖤 thanks for this! |
Fixes #508. Possibly requires changes to facilitate #394? Additionally, might want to make relevant deletions from https://github.com/exercism/cli.exercism.io per exercism/DEPRECATED.cli-www#34?
Completion scripts currently live in the CLI website repository which is
deemed inappropriate
Update build script to add shell completions and README to tar/zips