Don't run status command if API key is missing.#339
Merged
Tonkpils merged 1 commit intoexercism:masterfrom Jul 22, 2016
ests:fix-panic-for-status-cmd
Merged
Don't run status command if API key is missing.#339Tonkpils merged 1 commit intoexercism:masterfrom ests:fix-panic-for-status-cmd
Tonkpils merged 1 commit intoexercism:masterfrom
ests:fix-panic-for-status-cmd
Conversation
ests
changed the title
Contributor
|
Great, thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
exercism status rubycommand when API is missing (f.i. I've deleted config file) will make actual HTTP request and cause PANIC:%!v(PANIC=runtime error: invalid memory address or nil pointer dereference). I believe it should behave in the same way likesubmitcommand (prevent any requests and print message).