add check if the submitted filename is a directory#302
add check if the submitted filename is a directory#302kytrinyx merged 1 commit intoexercism:masterfrom alebaffa:submit-should-warn-users-that-try-to-check-in-a-directory
Conversation
cmd/submit.go
Outdated
| } | ||
|
|
||
| if paths.IsDir(filename) { | ||
| log.Fatal("You cannot submit a directory. Submit only the solution file.") |
There was a problem hiding this comment.
You can submit more than one file.
How about:
Please specify each file that should be submitted, e.g. `exercism submit file1 file2 file3`.
|
No, don't worry about a test. Eventually we'll be adding tests for the commands, but it's going to take some thought to get it right. |
|
Just for my curiosity: what are the considerations you are making for the tests for the commands? (don't know if it's the right place to ask this .. :P ) |
We are using a 3rd party library to handle the CLI interface. In order to test the commands we have to mock the argument passed into the command functions which would require a change of signature of all the functions to pass an interface of our own. However, the CLI package takes a specific struct which doesn't allow for this kind of change. Unless that's changed in the CLI package, that's the one thing stopping us from writing tests around the commands. |
|
This looks good to me. Would you mind squashing the commits, please? |
update the error message considering that the user can update more than one file.
|
Voila :) |
|
Lovely, thank you! |
|
Fixes #300 |
4 participants
I tried to add some tests, but I didn't know if to add a new one into_ paths/paths_test.go_ (so basically to testing the function IsDir()), or create a new cmd/submit_test.go.
Let me know if you need a test.