Skip to content

Enhance debug output when api key is absent#297

Merged
Tonkpils merged 1 commit intoexercism:masterfrom
mrageh:enhance-debug-output-when-api-key-is-not-set
Mar 5, 2016
Merged

Enhance debug output when api key is absent#297
Tonkpils merged 1 commit intoexercism:masterfrom
mrageh:enhance-debug-output-when-api-key-is-not-set

Conversation

@mrageh
Copy link
Contributor

@mrageh mrageh commented Mar 4, 2016

Previously if the API key was not, some of the features of exercism cli would
not work, for example exercism status.

This commit just prompts the user to set their API key to access the full
features of exercism cli, when its not set.

This fix was suggested in #296 by @Tonkpils

Previously if the API key was not, some of the features of exercism cli would
not work, for example exercism status.

This commit just prompts the user to set their API key to access the full
features of exercism cli, when its not set.
@Tonkpils Tonkpils self-assigned this Mar 5, 2016
} else {
fmt.Println("Config file: <not configured>")
fmt.Println("API Key: <not configured>")
fmt.Println("API Key: Please set your API Key to access all of the CLI features")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this with the <not configured> text as it's on the case where the CLI is not configured at all and it makes more sense.

@mrageh
Copy link
Contributor Author

mrageh commented Mar 5, 2016

@Tonkpils when I opened the exercism status issue, I didn't have exercism configured. Which meant that when I tried to run exercism status, the server returned a 500.

The message for the api key was not in helpful in the above instance. I think we should always prompt users to set their api key, when it's not set.

@Tonkpils
Copy link
Contributor

Tonkpils commented Mar 5, 2016

Right, this was an issue with the server, the server will now return the
appropriate message when the API key is not set which should fix the issue
of exercism status.

On Sat, Mar 5, 2016 at 9:58 AM Adam notifications@github.com wrote:

@Tonkpils https://github.com/Tonkpils when I opened the exercism status
issue, I didn't have exercism configured. Which meant that when I tried to
run exercism status, the server returned a 500.

The message for the api key was not in helpful in the above instance. I
think we should always prompt users to set their api key, when it's not
set.


Reply to this email directly or view it on GitHub
#297 (comment).

@Tonkpils
Copy link
Contributor

Tonkpils commented Mar 5, 2016

@mrageh actually it doesn't hurt to mention the message on both instances so 👍

Tonkpils added a commit that referenced this pull request Mar 5, 2016
…-is-not-set

Enhance debug output when api key is absent
@Tonkpils Tonkpils merged commit 1a20421 into exercism:master Mar 5, 2016
@mrageh mrageh deleted the enhance-debug-output-when-api-key-is-not-set branch March 17, 2016 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants