Encourage improvements after submission#262
Encourage improvements after submission#262kytrinyx merged 3 commits intoexercism:masterfrom eToThePiIPower:submit_extra_hints
Conversation
As per #77 I've added the "extra hints" from the "beer song" exercise README to the output of the submit command. These hints provide direction to help refactor, and then participate in the community through commenting on the exercism site. To keep annoyance down and keep users from getting used to (and thus ignoring) them, the extra hints will show only on a successful submission of the first iteration of each exercise.
To keep users from just automatically ignoring them, this adds some variety to the extra hints after submitting the first iteration, by randomly choosing from an assortment of header phrases.
cmd/submit.go
Outdated
There was a problem hiding this comment.
Would you make sure this is run through gofmt, please? goimports, would be good, too.
Moving the long, static text block for the "extra tips" to a const to reduce clutter in the Submit() function.
Encourage improvements after submission
|
Thanks! In the future, after pushing a fix, would you please add a comment that it has been done? I don't get notifications when someone pushes to a PR. |
|
Now that this has been in production for a bit... what do you think? |
|
So, I've used it a bit since this was implemented and I feel that after
|
|
That's been my impression as well. I think we should just take it back out, and keep working towards making the conversations on the site better. |
3 participants
As per issue #77, the displays extra hints after the users submit the first iteration of each problem.
The hints encourage users on ways to refactor, and then to participate in the community by commenting on their submission.
Variation is added through randomizing the opening phrase to keep users from automatically ignoring the message. Additional and more creative phrases here would be appreciated.