Conversation
The unsubmit command does not take any arguments, but it would be easy to assume that it does, considering how most of the other commands work. This changes the command so that it stops with a warning if someone tries to pass an argument. This change is in response to exercism/exercism#2446 where someone tried unsubmitting a submission by passing the file path to the unsubmit command, which blithely unsubmitted the most recent submission--period. It's confusing and unfriendly.
Tonkpils
added a commit
that referenced
this pull request
Jul 23, 2015
Add a guard to the unsubmit command.
Contributor
|
This looks great! |
Member
Author
|
Thanks, @Tonkpils! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unsubmit command does not take any arguments, but it would be
easy to assume that it does, considering how most of the other commands
work.
This changes the command so that it stops with a warning if someone
tries to pass an argument.
This change is in response to exercism/exercism#2446
where someone tried unsubmitting a submission by passing the file path
to the unsubmit command, which blithely unsubmitted the most recent
submission--period.
It's confusing and unfriendly.