Allow setting additional configuration options.#111
Merged
kytrinyx merged 1 commit intoexercism:masterfrom Sep 24, 2014
Merged
Conversation
Currently when you set one configuration option, it blows away
previously set configuration options.
If we set a custom directory, then the value is set.
$ exercism configure --dir="~/code/exercism"
The configuration has been written to /Users/josh/.exercism.json
Your exercism directory can be found at /Users/josh/code/exercism
$ cat ~/.exercism.json
{"apiKey":"","exercismDirectory":"/Users/josh/code/exercism","hostname":"http://exercism.io"}
However, when we set a key, the custom directory is blown away
$ exercism configure --key="abc123"
The configuration has been written to /Users/josh/.exercism.json
Your exercism directory can be found at /Users/josh/exercism
$ cat ~/.exercism.json
{"apiKey":"abc123","exercismDirectory":"/Users/josh/exercism","hostname":"http://exercism.io"}
Member
|
Thanks for the contribution! I don't see that the new |
Member
|
Actually, I have a few moments to finish this, I'm pulling it in. Thanks ❤️ |
kytrinyx
added a commit
that referenced
this pull request
Sep 24, 2014
Allow setting additional configuration options.
Contributor
Author
|
Yea, I submitted it before I actually used the |
lcowell
pushed a commit
to lcowell/cli
that referenced
this pull request
Jan 25, 2015
Allow setting additional configuration options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when you set one configuration option, it blows away previously set configuration options.
If we set a custom directory, then the value is set.
However, when we set a key, the custom directory is blown away