Conversation
FranckRJ
force-pushed
the
allow-moves-on-mocks
branch
from
5f19982 to
bb569e5
Compare
FranckRJ
force-pushed
the
allow-moves-on-mocks
branch
from
bb569e5 to
9428cd7
Compare
This was referenced May 10, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make mocks move-constructible, so they can be constructed from external functions. They could technically be move-assignable as well but I don't think it would be useful so I haven't done it.
They cannot be copy-constructible because the mocks can contain move-only objects (if a function returning a move-only object is mocked with
Return(MoveOnly{})then the mock will contain the move-only object that should be returned when that function is called), making them move-only as well.This should fix #283 and #97.