fix: use SA token for DWOC fetches in backup routes#1484
Merged
Conversation
Regular (non-admin) users got 403 Forbidden when the dashboard read the DevWorkspaceOperatorConfig (DWOC) — a cluster-level resource in the DWO namespace that regular users lack RBAC to access. Use the dashboard service account token for cluster-scoped reads (DWOC, registry auth secrets) and the user's token for namespace-scoped reads (DevWorkspaces, Jobs, ImageStreams). Assisted-by: Claude Opus 4.6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Contributor
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1484 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1484", name: che-dashboard}]}}]" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 563 563
Lines 54432 54439 +7
Branches 4121 4118 -3
=======================================
+ Hits 50826 50834 +8
+ Misses 3561 3560 -1
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
dkwon17
approved these changes
Mar 18, 2026
svor
approved these changes
Mar 18, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, dkwon17, svor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
akurinnoy
added a commit
that referenced
this pull request
Mar 19, 2026
Regular (non-admin) users got 403 Forbidden when the dashboard read the DevWorkspaceOperatorConfig (DWOC) — a cluster-level resource in the DWO namespace that regular users lack RBAC to access. Use the dashboard service account token for cluster-scoped reads (DWOC, registry auth secrets) and the user's token for namespace-scoped reads (DevWorkspaces, Jobs, ImageStreams). Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dkwon17
pushed a commit
that referenced
this pull request
Mar 19, 2026
Regular (non-admin) users got 403 Forbidden when the dashboard read the DevWorkspaceOperatorConfig (DWOC) — a cluster-level resource in the DWO namespace that regular users lack RBAC to access. Use the dashboard service account token for cluster-scoped reads (DWOC, registry auth secrets) and the user's token for namespace-scoped reads (DevWorkspaces, Jobs, ImageStreams). Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
This PR fixes
403 Forbiddenerrors on backup API endpoints for non-admin users. The PR splits the API clients so that cluster-scoped reads (DWOC, registry auth secrets) use the dashboard service account token, while namespace-scoped reads (DevWorkspaces, Jobs, ImageStreams) continue using the user's token.Depends on eclipse-che/che-operator#2099
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Is it tested? How?
Release Notes
Docs PR