docs: add cli generator#51
docs: add cli generator#51dgageot merged 14 commits intodocker:mainfrom ArthurFlag:ENGDOCS-2813-cli-docs
Conversation
crazy-max
left a comment
There was a problem hiding this comment.
You also need to add a job to validate docs similar to https://github.com/docker/model-cli/blob/main/.github/workflows/validate.yml
|
@crazy-max, David kindly fixed the problem, things are working now, would you mind taking a final look when you can? |
crazy-max
left a comment
There was a problem hiding this comment.
You also need to add a job to validate docs similar to https://github.com/docker/model-cli/blob/main/.github/workflows/validate.yml
See also my previous review for the Dockerfile
crazy-max
left a comment
There was a problem hiding this comment.
#15 0.694 ERROR: Docs result differs. Please update with "make docs"
#15 0.708 M docs/generator/reference/docker_mcp_gateway_run.yaml
|
mmmh, I can't reproduce locally, I'm not sure how to diagnose further, any idea? |
|
That's the because validation is based on merged pull request with base branch so you need to rebase and run I just tried on my side and it works. You can cherry-pick this commit if you want: crazy-max@1d676e1 |
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Co-authored-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
docs: add cli generator
No description provided.