Add blocklist for community registry MCP servers#447
Merged
cutecatfann merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
xenoscopic
approved these changes
Mar 17, 2026
jchangx
approved these changes
Mar 17, 2026
|
|
||
| for _, serverResp := range servers { | ||
| if slices.Contains(excludeServers, serverResp.Server.Name) { | ||
| skippedByType["excluded"]++ |
Contributor
There was a problem hiding this comment.
super nit: "blocked" is maybe more explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
--excludeflag todocker mcp catalog-next createfor filtering servers when creating catalogs from a community registry--from-community-registryThis is the
mcp-gatewayside of the server blocklist feature. Theai-mcpCI pipeline passes--excludeflags (derived fromserver-overrides.yaml) to this command when mirroring the community registry, allowing Docker to remove servers for takedown requests, security vulnerabilities, or policy violations.The
mcp-gatewaychanges must be merged and released first, since theai-mcpCI workflow depends on the--excludeflag being available in docker mcp catalog-next create. TheMCP_GATEWAY_VERSIONin both workflow files is currently pinned tov0.40.0, that version needs to be bumped to whatever release includes the--excludeflag before theai-mcpworkflow changes will work end-to-end.How to use
To block a server, add it to
server-overrides.yamlin ai-mcp:The server will be excluded from all pipeline stages (build, generate, upload, catalog, community registry mirror) on the next CI run. See
docs/runbook.mdfor full details including verification steps.Testing
go test ./pkg/catalog_next/ -run TestCreateFromCommunityRegistry -vall 5 community registry tests passgo test ./pkg/catalog_next/ -vfull suite passesgo vet ./...clean--excludewithout--from-community-registryreturns an error--excludewith--from-community-registrycorrectly omits named servers from the resulting catalog