Skip to content

Update Extensions SDK API ref with viewContainerTerminal#16608

Merged
aevesdocker merged 2 commits intodocker:mainfrom
felipecruz91:feature/navigate-to-term
Feb 27, 2023
Merged

Update Extensions SDK API ref with viewContainerTerminal#16608
aevesdocker merged 2 commits intodocker:mainfrom
felipecruz91:feature/navigate-to-term

Conversation

@felipecruz91
Copy link
Contributor

@felipecruz91 felipecruz91 commented Jan 27, 2023

Proposed changes

Update Extensions SDK API ref with viewContainerTerminal.

Related issues (optional)

@netlify
Copy link

netlify bot commented Jan 27, 2023 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 008b8bd
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63da1a65acbca70009149d86
😎 Deploy Preview https://deploy-preview-16608--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

aevesdocker
aevesdocker previously approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aevesdocker
Copy link
Contributor

aevesdocker commented Jan 27, 2023

@felipecruz91 is this to be published with DD 4.17?

@felipecruz91
Copy link
Contributor Author

felipecruz91 commented Jan 27, 2023

@aevesdocker Yes, let's coordinate it with @gtardif

@aevesdocker aevesdocker added this to the DD4.17 milestone Jan 27, 2023
lucbpz
lucbpz reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@lucbpz lucbpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a line with this in the dashboard-routes-navigation example?

gtardif
gtardif reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@gtardif gtardif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we should add a @since 0.3.4 in the code comment for this specific method, to let the users know in which version this has been introduced.

@felipecruz91
Copy link
Contributor Author

felipecruz91 commented Feb 1, 2023

@lucbpz Looking at the bottom of the dashboard-routes-navigation.md file, the methods listed are deprecated and will be removed in a future version. Those are the ones from v0 that start with navigateTo and have the window property (e.g. window.ddClient.navigateToContainerStats(id))

The viewContainerTerminal(id) is a new method and as such, it hasn't been added to the v0 API but to v1. Does it make sense?

@felipecruz91 felipecruz91 force-pushed the feature/navigate-to-term branch from 654a80e to 008b8bd Compare February 1, 2023 07:53
@gtardif
Copy link
Contributor

gtardif commented Feb 3, 2023

/merge

@gtardif gtardif added area/extensions Relates to Docker Extensions and removed merge/ready labels Feb 22, 2023
@aevesdocker aevesdocker merged commit ac8d5c7 into docker:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gtardif gtardif gtardif approved these changes

@aevesdocker aevesdocker aevesdocker approved these changes

@benja-M-1 benja-M-1 Awaiting requested review from benja-M-1

@lucbpz lucbpz Awaiting requested review from lucbpz

Assignees

No one assigned

Labels

area/extensions Relates to Docker Extensions

Projects

None yet

Milestone

DD4.17

Development

Successfully merging this pull request may close these issues.

5 participants

@felipecruz91 @aevesdocker @gtardif @lucbpz @docker-robott