Skip to content

Update extension publishing process#16592

Merged
aevesdocker merged 9 commits intodocker:mainfrom
benja-M-1:extensions/self-publish-process
Feb 27, 2023
Merged

Update extension publishing process#16592
aevesdocker merged 9 commits intodocker:mainfrom
benja-M-1:extensions/self-publish-process

Conversation

@benja-M-1
Copy link
Member

@benja-M-1 benja-M-1 commented Jan 25, 2023

Do not merge before the 4.17 Docker Desktop release

Proposed changes

We are in the process of updating how extensions are published in the marketplace. This process will be live when Docker Desktop 4.17 will be released, later in February.

See the overview of the process here : https://deploy-preview-16592--docsdocker.netlify.app/desktop/extensions-sdk/process/
See the publish page here : https://deploy-preview-16592--docsdocker.netlify.app/desktop/extensions-sdk/extensions/publish/

In the meantime, this PR fixes the toc from where the validate page was missing.

Related issues (optional)

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 94c9ceb
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63f61fb27b61b300083ac4af
😎 Deploy Preview https://deploy-preview-16592--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@benja-M-1 benja-M-1 added the area/extensions Relates to Docker Extensions label Jan 25, 2023
Copy link
Contributor

@amyb12345 amyb12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few suggestions still before approving.

@benja-M-1
Copy link
Member Author

@amyb12345 : @felipecruz91 told me that he felt there should a clearer explanation of what the advantages of requesting a review are. And maybe make it more clear that there are two ways to submit and what to expect from each in their own section maybe. I am working on it now

@benja-M-1 benja-M-1 force-pushed the extensions/self-publish-process branch from f122d22 to 82ee3e8 Compare January 25, 2023 17:19
Extension team before listing your extension. Whether you choose one or the other, the publishing process will be
different.

#### No review requested
Copy link
Member Author

@benja-M-1 benja-M-1 Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mention that a published not reviewed extension can request a review later?

@benja-M-1 benja-M-1 added this to the DD4.17 milestone Jan 25, 2023
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few picky comments @benja-M-1, rest LGTM

@benja-M-1 benja-M-1 force-pushed the extensions/self-publish-process branch from 55bfe36 to 40745a9 Compare January 27, 2023 00:13
amyb12345
amyb12345 previously approved these changes Jan 27, 2023
Copy link
Contributor

@amyb12345 amyb12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benja-M-1
Copy link
Member Author

benja-M-1 commented Jan 27, 2023

@aevesdocker, what is the best way to proceed on this one? Should I turn it as ready for review and you'll know when to merge it as it is attached to a milestone?

@aevesdocker
Copy link
Contributor

@benja-M-1 Yes, I'll take it from here! I won't miss anything attached to the milestone :)

benja-M-1 and others added 3 commits February 7, 2023 14:51
Introduce self-published and docker reviewd notions

Apply suggestions from code review

Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Co-authored-by: Felipe Cruz Martinez <15997951+felipecruz91@users.noreply.github.com>
@benja-M-1 benja-M-1 force-pushed the extensions/self-publish-process branch from 7bddeef to 37ad672 Compare February 7, 2023 14:01
@benja-M-1
Copy link
Member Author

I made some changes: I used the card component to make the two publish options more visible.

@aevesdocker aevesdocker marked this pull request as ready for review February 22, 2023 13:59
@aevesdocker aevesdocker merged commit 850fde2 into docker:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/extensions Relates to Docker Extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants